Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

betterchapters.lua -- wrong keybind names #15

Closed
Keith94 opened this issue Jan 24, 2019 · 4 comments
Closed

betterchapters.lua -- wrong keybind names #15

Keith94 opened this issue Jan 24, 2019 · 4 comments

Comments

@Keith94
Copy link

Keith94 commented Jan 24, 2019

In betterchapters.lua, it says the keybind names are chapter_next, chapter_prev. These don't do anything. The correct ones seem to be chapterplaylist-next, chapterplaylist-prev when added to input.conf.

@Argon-
Copy link
Owner

Argon- commented Feb 2, 2019

Indeed. Will update it from its source when I get around to it.
However, are you not using the version from mpv-player/mpv#4738 (comment) anyway?

@Keith94
Copy link
Author

Keith94 commented Feb 2, 2019

I was using that version previously, but I was seemingly limited to two key bindings unless I used a second copy of the .Lua file.

With your version... I can bind everything in input.conf just fine as long as I use the correct key bind names.

@Argon-
Copy link
Owner

Argon- commented Feb 2, 2019

No, this kind of calling a script from input.conf definitely works the same for both scripts. The question is just which keys to use.
I switched to the version linked above (https://github.com/Argon-/mpv-config/blob/master/scripts/betterchapters.lua#L20) but changed the name for keybindings so it is compatible with the previous version (chapterplaylist-next/chapterplaylist-prev)

@Argon- Argon- closed this as completed Feb 2, 2019
@Keith94
Copy link
Author

Keith94 commented Feb 3, 2019

OK now it's looking great. Thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants