Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On default runtime binary size #718

Closed
dcodeIO opened this issue Jul 17, 2019 · 2 comments
Closed

On default runtime binary size #718

dcodeIO opened this issue Jul 17, 2019 · 2 comments

Comments

@dcodeIO
Copy link
Member

dcodeIO commented Jul 17, 2019

As of #717 it seems that bundling the full runtime by default leads to confusion regarding binary file size. That's one thing I've been worried about when the runtime landed.

The underlying reason is that the full runtime exposes the runtime interfaces externally, so the loader can pick these up, and whatever is reached from the runtime exports becomes compiled. The alternative is to use the half runtime by default, which can properly DCE if none of its functionality is used, but will then lead to issues being opened asking why the loader isn't working as expected I guess.

Any ideas?

@MaxGraey
Copy link
Member

MaxGraey commented Jul 24, 2019

What about scan all exported functions and classes. If we have unmanaged types in arguments and return value like i32, bool, f64 we don't need full runtime and use half runtime as default.

@stale stale bot added the stale label Aug 23, 2019
@MaxGraey MaxGraey removed the stale label Aug 23, 2019
@AssemblyScript AssemblyScript deleted a comment from stale bot Aug 23, 2019
@dcodeIO
Copy link
Member Author

dcodeIO commented May 28, 2020

Closing this issue as part of 2020 vacuum because it cannot really be fixed. Also, there have been other improvements on this front meanwhile, like stripping cyclic garbage collection logic if it isn't needed.

@dcodeIO dcodeIO closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants