Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(completion): add codeium-cmp plugin #1030

Merged
merged 13 commits into from
Jun 10, 2024

Conversation

khas-amir
Copy link
Contributor

📑 Description

Add native codeium plugin for neovim

ℹ Additional Information

Copy link

github-actions bot commented Jun 7, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably split this up into two folders.

@khas-amir
Copy link
Contributor Author

@Uzaaft why ?

@Uzaaft
Copy link
Member

Uzaaft commented Jun 8, 2024

Nevermind, turns out the plugin doesn't provide virtual_text stuff. What a shame.

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Astrocore should be a dependency of the main plugin

@Uzaaft
Copy link
Member

Uzaaft commented Jun 9, 2024

@khas-amir We'd appreciate it if you next time follow the conventionsin this repository.

Uzaaft
Uzaaft previously approved these changes Jun 9, 2024
@Uzaaft Uzaaft dismissed their stale review June 9, 2024 20:34

Forgot about the astrocore stuff

@Uzaaft
Copy link
Member

Uzaaft commented Jun 9, 2024

Removed mapping that didn't make sense at all. Should be good to go now

Uzaaft
Uzaaft previously approved these changes Jun 9, 2024
@Uzaaft
Copy link
Member

Uzaaft commented Jun 9, 2024

Just tested before I merged this, and seems like the cmp lazy loading isn't working 🫠

@Uzaaft
Copy link
Member

Uzaaft commented Jun 9, 2024

Should be working now. @khas-amir Can you test before I merge this?

@Uzaaft Uzaaft dismissed their stale review June 9, 2024 21:52

Awaiting test after changes

@khas-amir
Copy link
Contributor Author

@Uzaaft everything works on my arch linux

@khas-amir
Copy link
Contributor Author

community.lua

return {
  { "AstroNvim/astrocommunity", dev = true },
  { import = "astrocommunity.colorscheme.catppuccin" },
  { import = "astrocommunity.motion.nvim-surround" },
  { import = "astrocommunity.pack.lua" },
  { import = "astrocommunity.pack.rust" },
  { import = "astrocommunity.pack.typescript" },
  { import = "astrocommunity.pack.tailwindcss" },
  { import = "astrocommunity.completion.codeium-nvim" },
}

``` `

@Uzaaft Uzaaft merged commit 5e6e95a into AstroNvim:main Jun 10, 2024
12 checks passed
@khas-amir khas-amir deleted the dev-add-codeium-cmp branch June 10, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants