Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chatgpt-nvim): add which-key mappings below <leader>G #1051

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

Kamilcuk
Copy link
Contributor

@Kamilcuk Kamilcuk commented Jun 18, 2024

📑 Description

Chatgpt.nvim has mapping recommendation in their readme. I think it makes a nice addition under <leader>G, G like gpt. I typically use <space>Gc to start a chat. Let me know what you think.

image

image

ℹ Additional Information

Copy link

github-actions bot commented Jun 18, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Kamilcuk Kamilcuk changed the title feat(chatgpt.nvim): add which-key mappings below <leader>G feat(chatgpt-nvim): add which-key mappings below <leader>G Jun 18, 2024
Uzaaft
Uzaaft previously approved these changes Jun 19, 2024
@Uzaaft Uzaaft dismissed their stale review June 19, 2024 11:08

Bug in code

@Uzaaft
Copy link
Member

Uzaaft commented Jun 19, 2024

Your mappings are wrong.

@Uzaaft
Copy link
Member

Uzaaft commented Jun 19, 2024

Fixing them myself.

@Uzaaft
Copy link
Member

Uzaaft commented Jun 19, 2024

@Kamilcuk Can you test it now? :)

@Kamilcuk
Copy link
Contributor Author

Kamilcuk commented Jun 19, 2024

Hi @Uzaaft .

Can you test it now?

I copied the code to my plugins/ and confirm it works nicely.

clarification: So here the code was changed from dependencies = { "astrocore", opts = { mappings = into opts = function(_ , opts) opts.mappigs[...] = .... Please kindly satisfy my curiosity. What was the reason for the change?

nonblocking, cosmetics: I am suprised by the choice of 󰭹 as the icon and I prefer and also observe the usage of 🤖 for chatgpt. But I don't care.

LGTM

Thanks.

@Uzaaft
Copy link
Member

Uzaaft commented Jun 20, 2024

@maxbrunet How about you, did you test it as well? I think we can combine the changes from your branch into this one if you'd prefer, feel free to suggest those and I'll commit them :)

@Kamilcuk I'll give you the reason of the change whenever I have time to write an explanation. Might take a while before I have time.

@Uzaaft Uzaaft merged commit e48e840 into AstroNvim:main Jun 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants