Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): Change command used for listing changed files in PR to the correct one. #1115

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

dwillett
Copy link
Contributor

📑 Description

The command registered for listing the changed files should use Octo pr changes, instead of listing the commits with Octo pr commits.

The mapping for listing changed files was set to the same command as the mapping for listing commits
Copy link

github-actions bot commented Jul 19, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@dwillett dwillett changed the title bug(git): fix command for listing changed files fix(git): appropriate command for listing changed files Jul 19, 2024
@Uzaaft Uzaaft changed the title fix(git): appropriate command for listing changed files fix(git): Change command used for listing changed files in PR to the correct one. Jul 20, 2024
@Uzaaft Uzaaft merged commit ed11b94 into AstroNvim:main Jul 20, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants