Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): update rustaceanvim to v5 #1133

Merged
merged 1 commit into from
Jul 28, 2024
Merged

feat(rust): update rustaceanvim to v5 #1133

merged 1 commit into from
Jul 28, 2024

Conversation

mehalter
Copy link
Member

📑 Description

This updates to the new Rustaceanvim v5 release. This drops support for neovim v0.9. To add backwards compatibility I simply copied the entired of the spec. This protects against if the opts change between the two or something the previous version will always be correct.

ℹ Additional Information

Copy link

github-actions bot commented Jul 26, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@mehalter mehalter requested a review from a team July 27, 2024 17:20
Copy link
Contributor

@ALameLlama ALameLlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do we want to include a note in the readme saying it'll get pinned based on your nvim version?

with backwards compatibility for neovim v0.9 being pinned to v4
@mehalter mehalter merged commit 45c60e7 into main Jul 28, 2024
14 checks passed
@mehalter mehalter deleted the rustaceanvim5 branch July 28, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants