Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transparent-nvim): make transparent.nvim actually work with Heirline (also makes the opts table work as well) #1149

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented Aug 9, 2024

📑 Description

This makes transparent.nvim actually work with Heirline now that features have been added that allow it to support it. This also fixes the fact that the transparent.nvim spec apparently wasn't using the opts table. So it's actually configurable by the user now.

ℹ Additional Information

@mehalter mehalter requested a review from a team August 9, 2024 16:28
Copy link

github-actions bot commented Aug 9, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@mehalter mehalter changed the title Transparent fix fix(transparent-nvim): make transparent.nvim actually work with Heirline (also makes the opts table work as well) Aug 9, 2024
Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Uzaaft
Copy link
Member

Uzaaft commented Aug 9, 2024

I fucking love that hamster

@Uzaaft Uzaaft merged commit ece293a into main Aug 9, 2024
19 of 20 checks passed
@Uzaaft Uzaaft deleted the transparent_fix branch August 9, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants