Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(go): remove golangcilint as default linter #1215

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

zedeus
Copy link
Contributor

@zedeus zedeus commented Sep 20, 2024

2467e24 'feat(go): Add golangcilint as default linter (#1213)'

📑 Description

ℹ Additional Information

2467e24 'feat(go): Add golangcilint as default linter (#1213)'
Copy link

github-actions bot commented Sep 20, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@mehalter mehalter changed the title Revert 'feat(go): Add golangcilint as default linter (#1213)' revert(go): remove golangcilint as default linter Sep 20, 2024
@mehalter mehalter merged commit ed63ebc into AstroNvim:main Sep 20, 2024
18 of 19 checks passed
@zedeus zedeus deleted the revert-golangcilint branch September 20, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants