Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colorscheme): lazy load all colorschemes #1218

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix(colorscheme): lazy load all colorschemes #1218

merged 1 commit into from
Sep 24, 2024

Conversation

mehalter
Copy link
Member

📑 Description

This adds lazy loading to all colorschemes by default. As of last week Telescope's colorscheme picker allows for picking lazy loaded colorschemes (nvim-telescope/telescope.nvim#3295)

ℹ Additional Information

@mehalter mehalter requested a review from a team September 24, 2024 14:38
Copy link

github-actions bot commented Sep 24, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

Copy link
Member

@luxus luxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i guess a lot people will love this

@luxus luxus merged commit 1d9046c into main Sep 24, 2024
14 checks passed
@luxus luxus deleted the lazy_colorscheme branch September 24, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants