Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(colorscheme): add monokai-pro #161

Merged
merged 4 commits into from
Apr 28, 2023
Merged

feat(colorscheme): add monokai-pro #161

merged 4 commits into from
Apr 28, 2023

Conversation

bernwo
Copy link
Contributor

@bernwo bernwo commented Apr 24, 2023

Adds the monokai-pro colorscheme.

@bernwo
Copy link
Contributor Author

bernwo commented Apr 24, 2023

This PR is ready for review. @luxus or anyone

@Uzaaft
Copy link
Member

Uzaaft commented Apr 26, 2023

LGTM. Just a question: Why not just use the default options for the setup? I.e just doing something like:

return {
    "loctvl842/monokai-pro.nvim", 
      opts = {}
}

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the opts table rather than config function with a setup call

It should be as simple as this:

{
    "loctvl842/monokai-pro.nvim",
    opts = {
      terminal_colors = true,
      devicons = true, -- highlight the icons of `nvim-web-devicons`
      filter = "pro", -- classic | octagon | pro | machine | ristretto | spectrum
      plugins = {
        indent_blankline = {
          context_highlight = "pro", -- default | pro
          context_start_underline = false,
        },
      },
    },
  }

also please make sure the code is formatted with stylua

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to the opts notation. LGTM

@mehalter mehalter merged commit 1f4d5b1 into AstroNvim:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants