Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(colorscheme): add nord #186

Merged
merged 7 commits into from
May 7, 2023
Merged

feat(colorscheme): add nord #186

merged 7 commits into from
May 7, 2023

Conversation

0xricksanchez
Copy link
Contributor

No description provided.

owittek
owittek previously requested changes May 4, 2023
View reviewed changes
Copy link
Member

@owittek owittek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this in my suggestion, whoops

lua/astrocommunity/colorscheme/nord-nvim/README.md Outdated Show resolved Hide resolved
lua/astrocommunity/colorscheme/nord-nvim/README.md Outdated Show resolved Hide resolved
@0xricksanchez 0xricksanchez marked this pull request as draft May 4, 2023 11:29
@luxus luxus marked this pull request as ready for review May 4, 2023 19:52
luxus
luxus previously requested changes May 4, 2023
View reviewed changes
Copy link
Member

@luxus luxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you using init and config?

@0xricksanchez
Copy link
Contributor Author

0xricksanchez commented May 5, 2023 •
edited
Loading

why are you using init and config?

Couldn't make it work with using opts. The current version at least seems to use the options from the init function. It does seem the nord theme doesn't have a setup() that can take opts

Also I had marked this as a draft as @owittek and I were debugging the additional configuration options on Discord (those mentioned in the README.md). They don't seem to apply yet and I have no idea why. If you can shed some light on that I'd be glad to make the appropriate changes to get this merged.

mehalter
mehalter approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a small simplification but looks great otherwise!

@mehalter mehalter dismissed stale reviews from owittek and luxus May 7, 2023 13:30

resolved

@mehalter mehalter merged commit e54077b into AstroNvim:main May 7, 2023
@mehalter mehalter mentioned this pull request May 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzaaft Uzaaft Uzaaft left review comments

@mehalter mehalter mehalter approved these changes

@owittek owittek owittek left review comments

@luxus luxus luxus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xricksanchez @luxus @mehalter @Uzaaft @owittek