fix(pack): java pack dependecy on mason-lspconfig #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: Samuel Cobb <[email protected]> Co-Authored-By: Olivier Wittek <[email protected]>
Co-Authored-By: Oli <[email protected]>
Uzaaft
pushed a commit
that referenced
this pull request
Jun 11, 2023
* fix: working haskell debug adapter * fix: lint * fix: lint * feat(pack): enable automatic install of haskell dap Author: Samuel Cobb <[email protected]> Co-Authored-By: Olivier Wittek <[email protected]> * fix(pack): working haskell dap Co-Authored-By: Oli <[email protected]> * fix: api changes * fjdsklfjdsklfklsadjfkl;dsalk;fd * dependency on mason-lspconfig * experimenting using just require * no dependencies test * add dependency on mason-lspconfig --------- Co-authored-by: Olivier Wittek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262
Given the most recent update to the mason registry, the config no longer internally required mason. This meant that
$MASONvariable was not loaded into scope causing the LSP to break. By requiring mason-lspconfig as a dependency, we ensure that$MASONis set.Also, to ensure that the debug adapter works properly, please ensure that mason is up to date using
:MasonUpdateAllor<leader>pM. (I spent 20 minutes trying to figure out what was wrong).Edit: Not sure why the changelog says there is an edit sorry. Also sorry for the messy tree