Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clojure): add space after clojure comment character #335

Merged

Conversation

practicalli-johnny
Copy link
Contributor

Add comment between ;; comment characters for clojure and text being commented

@mehalter mehalter changed the title fix: add space after clojure comment character fix(clojure): add space after clojure comment character Jun 30, 2023
@practicalli-johnny practicalli-johnny changed the title fix(clojure): add space after clojure comment character fix(pack): add space after clojure comment character Jun 30, 2023
@mehalter mehalter changed the title fix(pack): add space after clojure comment character fix(clojure): add space after clojure comment character Jun 30, 2023
@mehalter
Copy link
Member

@practicalli-john for the scope, and I should clarify this in the contribution guidelines, it should be the name of the already existing folder you are modifying. When you are adding a new plugin it is modifying the categories folder. When you are making changes to an already existing plugin the scope is the name of the plugin. This makes a very nice to read changelog.

@mehalter mehalter requested review from a team and removed request for a team June 30, 2023 17:17
@AstroNvim AstroNvim deleted a comment from github-actions bot Jun 30, 2023
@mehalter mehalter requested review from a team and removed request for a team June 30, 2023 17:19
@AstroNvim AstroNvim deleted a comment from github-actions bot Jun 30, 2023
@mehalter mehalter requested review from a team and removed request for a team June 30, 2023 17:23
@github-actions
Copy link

github-actions bot commented Jun 30, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@mehalter mehalter merged commit 1092abc into AstroNvim:main Jun 30, 2023
Uzaaft pushed a commit that referenced this pull request Jul 3, 2023
fix: add space after clojure comment character
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants