Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project): add ProjectMgr plugin #372

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

KenroLe
Copy link
Contributor

@KenroLe KenroLe commented Jul 6, 2023

Heres another one πŸ§‘β€πŸŒΎ

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@KenroLe KenroLe changed the title feat(utility): added ProjectMgr plugin feat(utility): add ProjectMgr plugin Jul 6, 2023
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Although I do think this will fit better in the project category that we have (more evidence for the upcoming refactor we want to do to allow multiple categories for plugins...)

@KenroLe
Copy link
Contributor Author

KenroLe commented Jul 6, 2023

Oh, i forgot to rename the pr

@KenroLe KenroLe changed the title feat(utility): add ProjectMgr plugin feat(project): add ProjectMgr plugin Jul 6, 2023
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mehalter mehalter merged commit 08f26a3 into AstroNvim:main Jul 6, 2023
@mehalter
Copy link
Member

mehalter commented Jul 6, 2023

oh shoot, I just realized naming issue. It should be projectmgr-nvim. I'll fix the commit

mehalter pushed a commit that referenced this pull request Jul 6, 2023
* feat(utility): added ProjectMgr plugin

wip

deleted sessionvim

* fix(project): Use VeryLazy instead of lazy = false in ProjectMgr conf
@mehalter
Copy link
Member

mehalter commented Jul 6, 2023

@KenroLe just a heads up, the name of the folder should be the entire repository name with the . replaced with - so projectmgr.nvim would be projectmgr-nvim. I revised the commit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants