Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(neotest): Fix bug in neotest by checking for existing library key table #440

Merged
merged 3 commits into from
Jul 14, 2023
Merged

fix(neotest): Fix bug in neotest by checking for existing library key table #440

merged 3 commits into from
Jul 14, 2023

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Jul 14, 2023 •
edited by mehalter
Loading

I’d let mehalter double check this one

Closes #406

@github-actions
Copy link

github-actions bot commented Jul 14, 2023 •
edited by mehalter
Loading

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft changed the title fix(neotest): Fix bug in neotest by extending table instead of insert… fix(neotest): Fix bug in neotest by extending table instead of inserting values at potential nil values Jul 14, 2023
@Uzaaft Uzaaft requested a review from owittek July 14, 2023 17:59
@Uzaaft Uzaaft mentioned this pull request Jul 14, 2023
Closed
mehalter
mehalter requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the incorrect approach @Uzaaft . The original method was correct, we just forgot to check if the library key was a table or not

lua/astrocommunity/test/neotest/init.lua Outdated Show resolved Hide resolved
mehalter
mehalter approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Uzaaft Uzaaft changed the title fix(neotest): Fix bug in neotest by extending table instead of inserting values at potential nil values fix(neotest): Fix bug in neotest by checking for existing library key table Jul 14, 2023
mehalter
mehalter requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

library.plugins can technically be true which I believe enables all plugins

lua/astrocommunity/test/neotest/init.lua Outdated Show resolved Hide resolved
mehalter
mehalter approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Uzaaft Uzaaft merged commit 9fd81bc into main Jul 14, 2023
@Uzaaft Uzaaft deleted the fix_neotest branch July 14, 2023 18:23
@mehalter mehalter mentioned this pull request Jul 14, 2023
Merged
mehalter added a commit that referenced this pull request Jul 15, 2023
@Uzaaft @mehalter
fix(neotest): Fix bug in neotest by checking for existing library key…
86640cc 
… table (#440)

Co-authored-by: Micah Halter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehalter mehalter mehalter approved these changes

@owittek owittek Awaiting requested review from owittek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add neodev integration for neotest community pack
2 participants
@Uzaaft @mehalter