Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editing-support): add nvim-neoclip plugin #450

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

tku137
Copy link
Contributor

@tku137 tku137 commented Jul 17, 2023

Adding plugin specifications for nvim-neoclip. Telescope integration and single key-binding under the find menu. Lazy loaded to minimise startup-time.

@github-actions
Copy link

github-actions bot commented Jul 17, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions to fix and also the folder name should be nvim-neoclip-lua because it shold be the direct repository name with . replaced with -

lua/astrocommunity/editing-support/nvim-neoclip/init.lua Outdated Show resolved Hide resolved
lua/astrocommunity/editing-support/nvim-neoclip/init.lua Outdated Show resolved Hide resolved
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! Looks awesome :D

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait...

@mehalter
Copy link
Member

@tku137 one more thing, the category here should be register and not editing-support as on neovim craft: http://neovimcraft.com/plugin/AckslD/nvim-neoclip.lua/index.html

@tku137
Copy link
Contributor Author

tku137 commented Jul 17, 2023

Oh snap! Changed that. Sorry.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is perfect. Thanks so much!

@mehalter mehalter merged commit 4ebda64 into AstroNvim:main Jul 17, 2023
@tku137
Copy link
Contributor Author

tku137 commented Jul 17, 2023

Thanks! I'm super happy to contribute :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants