Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debugging): add nvim-dap-repl-highlights #454

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

tku137
Copy link
Contributor

@tku137 tku137 commented Jul 18, 2023

Add nvim-dap-repl-highlights plugin. Tree-sitter setup needs to be called after plugin setup or dap_repl language won't be found. No opts for plugin setup, as far as I can see.

@github-actions
Copy link

github-actions bot commented Jul 18, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a restructure recommendations

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mehalter mehalter merged commit 2c8ecc9 into AstroNvim:main Jul 18, 2023
@tku137
Copy link
Contributor Author

tku137 commented Jul 18, 2023

Out of curiosity: the restructuring enables the use of list_insert_unique() on the ensure_installed list of tree sitter? Did I get that right?

@mehalter
Copy link
Member

Yeah just to make sure it's type safe and also provides the options that are being set in a way that the end user can override them if they need to. This also allows us to leverage the built in support for lazy.nvim to call setup rather than us specifying it manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants