-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(debugging): add nvim-dap-repl-highlights #454
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of a restructure recommendations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Out of curiosity: the restructuring enables the use of |
Yeah just to make sure it's type safe and also provides the options that are being set in a way that the end user can override them if they need to. This also allows us to leverage the built in support for lazy.nvim to call setup rather than us specifying it manually |
Add nvim-dap-repl-highlights plugin. Tree-sitter setup needs to be called after plugin setup or
dap_repl
language won't be found. Noopts
for plugin setup, as far as I can see.