Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(php): Add php-cs-fixer as formatter for php #476

Merged
merged 4 commits into from
Jul 23, 2023
Merged

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Jul 23, 2023

Closes #473

@github-actions
Copy link

github-actions bot commented Jul 23, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft mentioned this pull request Jul 23, 2023
Copy link
Member

@owittek owittek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to change this up before

lua/astrocommunity/pack/php/init.lua Outdated Show resolved Hide resolved
@Uzaaft Uzaaft requested a review from owittek July 23, 2023 19:09
lua/astrocommunity/pack/php/README.md Outdated Show resolved Hide resolved
@owittek owittek merged commit 81d63af into main Jul 23, 2023
@owittek owittek deleted the php_formatter branch July 23, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PHP formatter
3 participants