Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(smartcolumn-nvim): Add sensible default opts for when not to show colorcolumn #607

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

menoua
Copy link
Contributor

@menoua menoua commented Oct 14, 2023

📑 Description

Adds two filetypes (alpha, neo-tree) to the "smartcolumn" plugin's default list of disabled_filetypes (help, text, markdown). As both alpha-nvim and Neo-tree are included in the AstroNvim core and I see no reason why anyone would want a column in either case, I think it's a good idea to add them to the list of disabled filetypes.

ℹ Additional Information

This is the current behavior:
Screenshot 2023-10-14 at 7 47 52 PM

This is after the change:
Screenshot 2023-10-14 at 7 46 59 PM

@github-actions
Copy link

github-actions bot commented Oct 14, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@menoua menoua changed the title Disable colorcolumn in home screen and file tree fix(smartcolumn-nvim): Add sensible default opts for when not to show colorcolumn Oct 14, 2023
@Uzaaft Uzaaft self-requested a review October 17, 2023 16:50
@Uzaaft Uzaaft merged commit c624e8a into AstroNvim:main Oct 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants