Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transparent-nvim): Made cursor line transparent #611

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

Infonautica
Copy link
Contributor

@Infonautica Infonautica commented Oct 17, 2023

📑 Description

Adjusted groups to include cursor line, so it can be transparent as well

Before:
Note the line where cursor is
before-bg

After:
after-bg

ℹ Additional Information

PR has a couple of unwanted commits (at first i didn't know this package exists already), so i can re-create this PR from scratch if that's a problem

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution 🥳

@mehalter mehalter merged commit cae8e92 into AstroNvim:main Oct 18, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants