Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): add thrift pack #620

Merged
merged 1 commit into from
Oct 23, 2023
Merged

feat(pack): add thrift pack #620

merged 1 commit into from
Oct 23, 2023

Conversation

chaozwn
Copy link
Contributor

@chaozwn chaozwn commented Oct 23, 2023

📑 Description

ℹ Additional Information

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@chaozwn chaozwn changed the title feat: add thrift lsp language. feat(pack): add thrift lsp language. Oct 23, 2023
@Uzaaft Uzaaft changed the title feat(pack): add thrift lsp language. feat(pack): add thrift pack Oct 23, 2023
@Uzaaft Uzaaft merged commit 2ffcf86 into AstroNvim:main Oct 23, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants