Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(media): add image.nvim #742

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Conversation

belafonte
Copy link
Contributor

I recently came across this nvim plugin:
https://github.com/3rd/image.nvim

Which can display images in astronvim via kittys image protocol, which is neat!
Works very well and also prevents astronvim from crashing when opening images :).

It has some requirements, so it does not work out of the box though.
I have only tested it with kitty.

Happy to discuss it or change something if it seems wrong.

Copy link

github-actions bot commented Jan 29, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft merged commit 6398af8 into AstroNvim:main Feb 4, 2024
12 checks passed
@Uzaaft
Copy link
Member

Uzaaft commented Feb 4, 2024

This might require some changes in the future but seems good to go for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants