Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grapple-nvim): better keymaps + add nvim-web-devicons dependency #781

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

cbochs
Copy link
Contributor

@cbochs cbochs commented Mar 2, 2024

📑 Description

Hello, again 👋

I received a bit of feedback after releasing the rewrite the other day. Thought I would send one more PR to address that here as well 🙂

Changes

  • Add nvim-tree/nvim-web-devicons as a lazy (optional) dependency
  • Use toggle_* instead of open_* so Grapple windows can be open/closed with the same mapping

Copy link

github-actions bot commented Mar 2, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbochs Thank you for the PR!

@Uzaaft Uzaaft changed the title fix(grapple-nvim): better keymaps + add nvim-web-devicons dependency feat(grapple-nvim): better keymaps + add nvim-web-devicons dependency Mar 3, 2024
@Uzaaft Uzaaft merged commit c730a7e into AstroNvim:main Mar 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants