Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image-nvim): use luarocks.nvim for "magick" rock #835

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

FraI3mega
Copy link
Contributor

📑 Description

Change the image.nvim plugin init.lua to use luarocks.nvim for adding the "magick" rock. Removes a step from the installation.

ℹ Additional Information

It adds luarocks.nvim as a dependency

@FraI3mega FraI3mega closed this Apr 5, 2024
@FraI3mega FraI3mega reopened this Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@FraI3mega FraI3mega marked this pull request as ready for review April 5, 2024 19:25
Uzaaft
Uzaaft previously approved these changes Apr 7, 2024
@Uzaaft Uzaaft dismissed their stale review April 7, 2024 09:55

Unsure if it's a breaking change.

@Uzaaft Uzaaft merged commit 6a58f1d into AstroNvim:main Apr 7, 2024
21 checks passed
This was referenced Apr 7, 2024
@FraI3mega FraI3mega deleted the dev-image-nvim-luarocks branch May 7, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants