Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markmap-nvim): Fix issue with pack due to wrongly named null-ls package, and load on md file #886

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

javierEd
Copy link
Contributor

📑 Description

  • Also place "Zeioth/markmap.nvim" with specs inside brackets.
  • And load only with markdown files.

* Place `"Zeioth/markmap.nvim"` with specs inside brackets.
* And load only with markdown files.
Copy link

github-actions bot commented Apr 15, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft changed the title fix(markmap-nvim): the package in Mason is named markmap-cli fix(markmap-nvim): Fix issue with pack due to wrongly named null-ls package, and load on md file Apr 15, 2024
@Uzaaft Uzaaft merged commit 1f6c37d into AstroNvim:main Apr 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants