Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): support avante.nvim #139

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Aug 27, 2024

Signed-off-by: Aaron Pham [email protected]

📑 Description

Add support for yetone/avante.nvim colorscheme. I'm not entirely sure what to do with the diff color here, see yetone/avante.nvim#283.

The current color I have for diff is not in the palette. Would definitely need a second opinion here.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks so much for the addition! Made one comment about the hardcoded values in the config, and the only other thing is to please update the README file with the new plugin and a link to it's repo!

lua/astrotheme/groups/plugins/avante.lua Outdated Show resolved Hide resolved
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great. A couple other nitpicks and then it's good to go. I have also pushed to main the updates to the diff highlight groups so it should be good to go as well

README.md Outdated Show resolved Hide resolved
lua/astrotheme/groups/plugins/avante.lua Outdated Show resolved Hide resolved
aarnphm and others added 2 commits August 27, 2024 15:14
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks so much again for the contribution!

@mehalter mehalter merged commit 199a2ab into AstroNvim:main Aug 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants