Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(treesitter): add <?php ... ?> highlights #144

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

AlejandroSuero
Copy link
Contributor

📑 Description

Improving distinction when it comes to @punctuation.bracket.php -> <?php ... ?>.

ℹ Additional Information

Before:

Screenshot 2024-09-15 at 05 18 32

After:

Screenshot 2024-09-15 at 05 23 49

Copy link
Contributor

@A-Lamia A-Lamia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why this is made bold ?

I can't really tell but in your code examples it seems like it is not bold.

@AlejandroSuero
Copy link
Contributor Author

@A-Lamia seems that linking with keyword doesn't let to modify bold = true.

Screenshot 2024-09-15 at 07 31 42

With the latest commit, it's fixed.

Copy link
Contributor

@A-Lamia A-Lamia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM!

@A-Lamia
Copy link
Contributor

A-Lamia commented Sep 15, 2024

seems to be a problem with vimdoc, lets get the boss here as i have no idea what his magic setup is @mehalter

@mehalter
Copy link
Member

Ah looks like the Lua language server changed their API for generating docs. I'll check it out early this upcoming week and get this fixed and merged. Sorry!

@AlejandroSuero
Copy link
Contributor Author

@mehalter the changes seem to be on this PR LuaLS/lua-language-server#2821 and the official docs with --doc_out_path, --logpath seems to be now for the cli logs.

@mehalter mehalter merged commit 4ef753c into AstroNvim:main Sep 15, 2024
12 checks passed
@AlejandroSuero AlejandroSuero deleted the feature/add-php-tag-hl branch September 15, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants