Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate/redundant data-shift reports #106

Open
thesoftwarephilosopher opened this issue May 13, 2022 · 3 comments
Open

Avoid duplicate/redundant data-shift reports #106

thesoftwarephilosopher opened this issue May 13, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@thesoftwarephilosopher
Copy link
Contributor

thesoftwarephilosopher commented May 13, 2022

Essentially, we're sometimes seeing the same data-shift errors being reported several times in a row, when once would be enough.

I'm not sure what the right solution is right now. Putting this here so we can prioritize it and have a centralized place to discuss it.

But my gut feeling is that each type of data-shift error needs its own way of checking:

  1. "Late transactions/licenses" needs to check against all past data sets, but only look in the current data set for new appearances
  2. "Deleted transactions/licenses" also doesn't need to check every past data set against every data set before it, only the current one
  3. I haven't thought of the other ones, as these are the only types we've dealt with so far for this issue
@thesoftwarephilosopher thesoftwarephilosopher added the enhancement New feature or request label May 13, 2022
@bberenberg
Copy link
Contributor

Why not take the "error message", hash the raw text, store the hash, don't print messages with stored hashes?

@thesoftwarephilosopher
Copy link
Contributor Author

Because that would make too much sense 🤦

@boris-moduscreate
Copy link
Contributor

boris-moduscreate commented Oct 12, 2022

Prob an env variable here where we set the max number of times a given error is posted? Default 1
And a second option where all records are wiped out after a successful run? Default disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants