Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hubspot API #164

Open
modusjorge opened this issue May 17, 2023 · 0 comments
Open

Update hubspot API #164

modusjorge opened this issue May 17, 2023 · 0 comments

Comments

@modusjorge
Copy link
Contributor

Audit reveals current Hubspot APIhas a moderate vulnerability:
$ npm audit

npm audit report

request *
Severity: moderate
Server-Side Request Forgery in Request - GHSA-p8p7-x288-28g6
fix available via npm audit fix --force
Will install @hubspot/[email protected], which is a breaking change
node_modules/request
@hubspot/api-client <=5.0.0
Depends on vulnerable versions of request
node_modules/@hubspot/api-client

2 moderate severity vulnerabilities

To address all issues (including breaking changes), run:
npm audit fix --force

Upgrade to latest version for fix, however, upgrade is a breaking change, and I have confirmed it does break the download of data.
Needd to upgrade and fix issues caused by upgrade.
Issues found so far:

Downloading:
`$ npm run download

[email protected] download
node out/bin/download.js

5/17/2023, 4:08:23 PM info Downloader Starting downloads with API
[ ] Tlds
[ ] Licenses With Data Insights
[ ] Licenses Without Data Insights
[ ] Transactions
[■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■] Free Email Providers
[ ] Deals
[ ] Companies
Error: Failed downloading contacts. ] Contacts
Response body: undefined
Error stacktrace: Error: HTTP-Code: 400
Message: An error occurred.
Body: {"status":"error","message":"You can only request at most 50 objects in one request for properties with history.","correlationId":"e8}
Headers: {"access-control-allow-credentials":"false","alt-svc":"h3=":443"; ma=86400, h3-29=":443"; ma=86400","cf-cache-status":"DYNAMIC}
at BasicApiResponseProcessor. (/home/jorge/code/modus/marketing-automation/node_modules/@hubspot/api-client/codegen/crm/cont)
at Generator.next ()
at fulfilled (/home/jorge/code/modus/marketing-automation/node_modules/@hubspot/api-client/lib/codegen/crm/contacts/apis/BasicApi.js:5:)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at HubspotAPI.downloadHubspotEntities (/home/jorge/code/modus/marketing-automation/src/lib/hubspot/api.ts:65:15)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at MultiDownloadLogger.wrap (/home/jorge/code/modus/marketing-automation/src/lib/log/download.ts:20:20)
at async Promise.all (index 7)
at downloadAllData (/home/jorge/code/modus/marketing-automation/src/lib/engine/download.ts:19:16)
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant