Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vitest global types to encourage vitest imports and prevent misconfig errors #152

Closed
mikeybinns opened this issue Aug 14, 2024 · 0 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed Package: Coding Standards Issues related to the Coding Standards package

Comments

@mikeybinns
Copy link
Member

Our vitest typescript config currently loads vitest functions as global variables, which means they don't throw and error if they aren't imported.

To fix this issue, we should remove global import types and require vitest consumers to import their functions explicitly.

@mikeybinns mikeybinns added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed Package: Coding Standards Issues related to the Coding Standards package labels Aug 14, 2024
@mikeybinns mikeybinns self-assigned this Oct 22, 2024
@mikeybinns mikeybinns linked a pull request Oct 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed Package: Coding Standards Issues related to the Coding Standards package
Projects
None yet
Development

No branches or pull requests

1 participant