Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flippable Effects #636

Closed
Crystal2002 opened this issue Feb 11, 2022 · 7 comments · Fixed by #701
Closed

Flippable Effects #636

Crystal2002 opened this issue Feb 11, 2022 · 7 comments · Fixed by #701
Labels
engine/viewport Issues related to viewport positioning and layering enhancement Request for functionality not present

Comments

@Crystal2002
Copy link

Crystal2002 commented Feb 11, 2022

Is your feature request related to a problem? Please describe.
Not really a problem, but it would be nice to have a way to tell the client that certain effects should be affected by "Flip" being checked and others shouldn't be. Some people do use the Effects system as a "Character Overlay" system to help cut down on custom content filesize, so having this would exponentially assist them in keeping the sizes down.

Describe the solution you'd like
We currently have effects.ini that keeps track of if the effect should be stretched and if it should be rendered over or under the chatbox. Perhaps another variable could be added to this for if the effect should be flipped, with the default setting as that effects will not flip.\

Additional context
What currently happens when a character w/ an effect is flipped (the effect layer is the visor):

Mockup of intended behavior:

Sample Files:
Black Heart w/ Effects

@Crystalwarrior
Copy link
Contributor

I suggest to provide a file download for an example of your effects usage so the developers have an easy reference to test

@stonedDiscord
Copy link
Member

grafik

@Crystal2002
Copy link
Author

I suggest to provide a file download for an example of your effects usage so the developers have an easy reference to test

Yepyep, here's the character files that was used for this post, I'll also append the original message w/ it.

Black Heart w/ Effects

@oldmud0 oldmud0 added engine/viewport Issues related to viewport positioning and layering enhancement Request for functionality not present labels Feb 14, 2022
@Crystalwarrior Crystalwarrior added this to the 2.10 milestone Feb 15, 2022
@Crystalwarrior
Copy link
Contributor

Seems better suited for #490 than the effects system

@Crystalwarrior
Copy link
Contributor

Actually now I slept on it is there even any harm to giving an option to flip effects, there's like no downsides and it's easy enough to add

@oldmud0
Copy link
Member

oldmud0 commented Feb 21, 2022

How would one specify that an effect should not be flipped when the emote is set to flip?

@Crystalwarrior
Copy link
Contributor

How would one specify that an effect should not be flipped when the emote is set to flip?

In the .ini,
_respect_flip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine/viewport Issues related to viewport positioning and layering enhancement Request for functionality not present
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants