Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect Offsets w/ Character #639

Closed
Crystal2002 opened this issue Feb 11, 2022 · 2 comments · Fixed by #663
Closed

Effect Offsets w/ Character #639

Crystal2002 opened this issue Feb 11, 2022 · 2 comments · Fixed by #663
Labels
enhancement Request for functionality not present

Comments

@Crystal2002
Copy link

(Most of this is Copy/Pasted from my previous request, since it's pretty much same everything)

Is your feature request related to a problem? Please describe.
Not really a problem, but it would be nice to have a way to tell the client that certain effects should be affected by the X/Y offsets being checked and others shouldn't be. Some people do use the Effects system as a "Character Overlay" system to help cut down on custom content file size, so having this would exponentially assist them in keeping the sizes down.

Describe the solution you'd like
We currently have effects.ini that keeps track of if the effect should be stretched and if it should be rendered over or under the chatbox. Perhaps another variable could be added to this for if the effect should move with offsets, with the default setting as that effects will not offset.

Additional context
What currently happens when a character w/ an effect is slid (the effect layer is the visor):

Mockup of intended behavior:

Sample Files:
Black Heart w/ Effects

@oldmud0 oldmud0 added the enhancement Request for functionality not present label Feb 14, 2022
@Crystalwarrior Crystalwarrior added this to the 2.10 milestone Feb 15, 2022
@in1tiate
Copy link
Member

Possible alternative way of achieving this was developed in #490. @Crystalwarrior, thoughts?

@Crystalwarrior
Copy link
Contributor

@in1tiate No harm supporting it for the effects system, as this system can also be used for effects such as Danganronpa gloom, sparkles, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for functionality not present
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants