Code compiling open questions/issues

[Schwartz10]

1. react, react-dom, and styled-components should not be bundled into the published package. Since aragon client has these dependencies, it will create conflicts when two versions are used in the client repo (and hooks will break).

• Relevant issues: NPM link local react hooks library reporting errors: Hooks can only be called inside the body of a function component. webpack/webpack#8607 Library included multiple times in bundle code webpack/webpack#8886
• I got this working in rollup, but can't seem to figure it out in webpack + npm link
• Does this require any changes in the aragon/aragon repo? I don't think it should...

2. Figure out why there are dependencies missing

• This is a question for 3box - for some reason you have to add 3box's babel deps in order to bundle their code. Still working on this one...

3. which bundler to use?

• Rollup was working for everything... Except bundling 3box. 3Box exports ES5 code but without bundling their packages. Their reasoning for this is to allow devs to have more flexibility on how 3box's deps get bundled (tree shaking). More on that here Unable to build project with 3box - vue-cli - Allocation failed - JavaScript heap out of memory 3box/3box-js#408 (comment). Turns out this is (most likely) the underlying issue: Getting IPFS to work with ES Modules and Rollup ipfs/js-ipfs#1927
• I could get things to bundle when i hiked up the amount of memory available to the build process. However, then we'd have to change the build scripts in aragon/aragon in order to get this to work.
• Switched to webpack because it bundled 3box fine, but then of course ran into the issue with multiple reacts

[Schwartz10]

styled-components/styled-components#1941 (comment)