Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new accounts with manual entry is broken #1262

Closed
vinitha0708 opened this issue Aug 21, 2024 · 10 comments · Fixed by #1264
Closed

Adding new accounts with manual entry is broken #1262

vinitha0708 opened this issue Aug 21, 2024 · 10 comments · Fixed by #1264
Labels
bug Something isn't working P1 Issues must be resolved

Comments

@vinitha0708
Copy link

vinitha0708 commented Aug 21, 2024

Describe the issue

while doing manual entry it's not showing the code

Browser

Chrome

Browser Version

127.0.6533.120

Extension Version

8.0.0

@vinitha0708 vinitha0708 added the bug Something isn't working label Aug 21, 2024
@jooname
Copy link

jooname commented Aug 21, 2024

Adding further details as I'm also getting issues with manual entry. I have the same versions, so Chrome is 127.0.6533.120 (updated today) and the extension is 8.0.0. I did not have this issue earlier.

Problem: clicking ok on manual entry does nothing, so you cannot add new entries manually
Expected: clicking ok should add new entry to the tool and start showing the codes

Replication steps:

  1. Open the tool from browser extensions as usual
  2. Click the pen icon on top right
  3. Click the plus icon that appears
  4. Select manual entry
  5. Fill in issuer and secret
  6. Try to click OK

Right-clicking the tool does allow me to inspect it and there I can see following error coming up when you click OK:

TypeError: n.getEncryptionStatus is not a function
    at Rs.getOTPStorageFromEntry (storage.ts:214:39)
    at Rs.<anonymous> (storage.ts:562:26)
    at Generator.next (<anonymous>)
    at otp.ts:290:3
    at new Promise (<anonymous>)
    at Is (otp.ts:290:3)
    at Rs.add (storage.ts:560:20)
    at Ds.<anonymous> (otp.ts:167:24)
    at Generator.next (<anonymous>)
    at otp.ts:27:13

As far as I could see the issuer and secret values made no difference and modifying the advanced settings also made no difference.

@mymindstorm
Copy link
Member

Thanks for the report! As a workaround, you should be able to do a text backup import using the string otpauth://totp/?secret=[your secret here, no whitespace]

@Sneezry
Copy link
Member

Sneezry commented Aug 21, 2024

@mymindstorm is this a regression? I took a quick look but haven't yet identified the root cause.

@Sneezry Sneezry added the P1 Issues must be resolved label Aug 21, 2024
@mymindstorm
Copy link
Member

Think so but can't investigate until Sunday

@Sneezry
Copy link
Member

Sneezry commented Aug 21, 2024

No worry. I will take a look first.

@Sneezry
Copy link
Member

Sneezry commented Aug 21, 2024

@landmark3138
Copy link

I tried with chrome, edge, firefox and brave; none worked

@Sneezry
Copy link
Member

Sneezry commented Aug 23, 2024

Hotfix has been submitted to Google

@mymindstorm could you help to submit v8.0.1 to Mozilla and Microsoft, thanks.

@cipineda
Copy link

It seems version 8.0.1 fixed this issue, is there a way to upgrade existing the extension (version 8.0.0) to 8.0.1?
I tried removing the extension and re-installing from https://authenticator.cc but still get version 8.0.0.

@mymindstorm
Copy link
Member

@cipineda I submitted the update to Microsoft, but it is pending review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 Issues must be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants