Git traffic and tokenless authentication charts empty after GHE upgrade #139
Comments
|
similarly no data (or marked as zero against date) in |
|
Hi @talktopiyush! Thanks for reaching out about these two issues. We noticed the issues with the Git traffic charts as well, and they should be fixed by #138. I’d like you to check out the latest commit in the Concerning the tokenless authentication chart, there was a change in GitHub’s log file format from 2.11 to 2.12 that broke our script for that chart’s data. I’m currently working on this and hope to have a patch out later today. As a general suggestion, we recommend that you use the latest release (currently, 0.2.0) and not the |
|
@talktopiyush: In the meantime, please let me know whether #138 fixed the issues you experienced with the Git traffic charts. |
pluehne
changed the title
|
@talktopiyush: I forgot to notify you, but we merged my fix #141 that should resolve your issue with the tokenless authentication chart. It would be great if you could test all these changes and tell me whether we can close this issue 😃. |
|
Hi @pluehne post upgrading, i can confirm Git Traffic Chart is populating data but tokenless-authentication-detailed.tsv FAILS, please note tokenless authentication.tsv gets updated. |
|
@rajivmucheli: Happy to hear that the Git traffic chart is fixed for you now. Can you explain what exactly fails with the detailed tokenless authentications report? Is it just empty or do you get an error message? Also note that the tokenless authentications chart has recently received a fix in #141. Did you experience the issue before or after this pull request had been merged? |
|
The report doesn’t process i.e wouldn’t update like other reports. Hubble-data repo for this repo shows last updated was 16th March, which was we updated GHE to 2.12. I guess after the pull request? I see this fox was on 16th March as well! |
|
@rajivmucheli: Do you get any errors in the log? GitHub Enterprise 2.12 is meant to be supported by Hubble, so this shouldn’t be a problem. Also, could you try manually executing |
|
@talktopiyush: It would be interesting for me to know whether you’re facing the same issues as @rajivmucheli 🙂. If everything is resolved for you, I’d like to close this very issue and to open a new one for the problems with the detailed tokenless authentications chart that @rajivmucheli is facing. |
|
@pluehne we are in the same work group :) |
|
@talktopiyush: That’s what I suspected, but I wanted to make sure that these aren’t two unrelated issues 😄. If you have the time, it would help if you could try what I suggested above a few minutes ago 🙂. |
|
@pluehne We have updated hubble to the latest commit. hopefully tomorrow this will get populated. keep you posted. myself or @rajivmucheli will keep you posted. thanks for the help |
|
@talktopiyush, @rajivmucheli: All right, and thanks for helping us debug the issue 🙂! |
|
I am not sure if the latest updated fixed the issue, i initially executed update-stats.py manually but had no luck. As suggested by you, (i gave chmod +x tokenless-auth.sh) to the script, o/p is: [scripts]# ./tokenless-auth.sh Prior to the upgrade it worked well, hence would creating the above directories help? |
|
@rajivmucheli: Just to be sure, did you execute |
|
@pluehne hope there wont be any impact? to confirm i copy the script & execute? |
|
I generally recommend you review whatevery you intend to execute on a GitHub Enterprise appliance. As you will see, From my experience, the script doesn’t take long to complete (less than a minute, I would expect), and it is executed with each call of |
|
the scrip executes successfully, gives me tons of user info (like it initially worked): ./token.sh |
|
@rajivmucheli: Good, that means that the script itself is working as expected. Hence, I would think that the tokenless authentications are correctly collected by Hubble’s updater. Out of curiosity, can you confirm that the (confidential) output you got is indeed different from the Also, can you once again look at whether |
|
Yes, output is indeed different from the tokenless-authentication-detailed.tsv. I uncommented all the other reports & the script went well: python3 update-stats.py Started update of tokenless-authentication.tsv /tmp/hubble-data/tokenless-authentication.tsv Initially, tokenless-authentication-detailed.tsv would not show in the list when update-stats.py is executed, but post a executing the shell script on GHE yesterday may have done the trick. python3 update-stats.py Started update of tokenless-authentication.tsv /tmp/hubble-data/tokenless-authentication.tsv To [email protected]:github/hubble-data.git Finished update of GitHub usage statistics Started update of api-requests.tsv /tmp/hubble-data/api-requests.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/contributors-by-organization.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/contributors-by-repository.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/forks-to-organizations.tsv /tmp/hubble-data/git-download.tsv /tmp/hubble-data/git-requests.tsv /tmp/hubble-data/git-versions.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/organization-activity.tsv mysql: [Warning] Using a password on the command line interface can be insecure. mysql: [Warning] Using a password on the command line interface can be insecure. mysql: [Warning] Using a password on the command line interface can be insecure. mysql: [Warning] Using a password on the command line interface can be insecure. mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/org-collaboration.tsv /tmp/hubble-data/org-owners.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/organizations-abandoned.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/orgs-total.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/pull-requests-by-organization.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/pull-requests-by-repository.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/pull-request-history.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/pull-request-usage.tsv mysql: [Warning] Using a password on the command line interface can be insecure. mysql: [Warning] Using a password on the command line interface can be insecure. mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/repository-activity.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/repository-history.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/repositories-personal-nonowner-pushes.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/repository-usage.tsv /tmp/hubble-data/teams-legacy.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/teams-total.tsv mysql: [Warning] Using a password on the command line interface can be insecure. /tmp/hubble-data/users.tsv Have a good one 👍 |
|
@rajivmucheli: Happy to hear that you got updated data now. However, I don’t see a reason why it didn’t work before but it does now. Let’s give it a few days. Could you tell me by the end of the week whether you got updates with the detailed tokenless authentications report every day without trouble? |
|
@rajivmucheli, @talktopiyush: Is everything still working fine on your end? I’d just like to know whether we can close this issue 🙂. |
|
Yes it works again. thanks |
|
@talktopiyush: Thanks for the update! |
|
@pluehne maybe you could confirm this, graph are updated only once in a day regardless of how many times we execute the python script? |
|
@talktopiyush: Yes. If Hubble detects that there already is data from today for a given chart, it will not update the chart again. That’s to avoid recording duplicate values in the data files. |
|
@rajivmucheli this confirms why we did not have any data in the graphs even after update to the latest release on that day but it populated the next day. |
|
@pluehne thanks again |
|
@talktopiyush: Yep, I should have thought about this. In these cases, it’s necessary to remove the most recent Hubble commit, at least for testing 🙂. I’m happy to help. Feel free to stay in touch with us should you have suggestions or other comments. |
Hello there,
We have hubble as service on a dedicated machine and we recently did GHE upgrade from v2.11 to v2.12.6 and after this hubble does not show the git traffic/ there is no data in git-download.tsv
fyi, there are no errors reported when we run
update-stats.py.In general do we need to do anything before or after we apply an update to GHE.
Regards
Piyush
The text was updated successfully, but these errors were encountered: