From 885e234e01becfac3eba2297d4618935760044b4 Mon Sep 17 00:00:00 2001 From: Varjitt Jeeva Date: Fri, 6 Sep 2024 14:02:13 -0400 Subject: [PATCH] fix: support for capital letters in sequence names (#548) --- pgbelt/util/postgres.py | 6 +++--- tests/integration/files/test_schema_data.sql | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/pgbelt/util/postgres.py b/pgbelt/util/postgres.py index 58d1195..d18cecb 100644 --- a/pgbelt/util/postgres.py +++ b/pgbelt/util/postgres.py @@ -15,9 +15,9 @@ async def dump_sequences( # Get all sequences in the schema seqs = await pool.fetch( f""" - SELECT '{schema}' || '.' || sequence_name + SELECT '{schema}' || '.\"' || sequence_name FROM information_schema.sequences - WHERE sequence_schema = '{schema}'; + WHERE sequence_schema = '{schema}' || '\"'; """ ) @@ -28,7 +28,7 @@ async def dump_sequences( proper_sequence_names = [] for seq in targeted_sequences: if f"{schema}." not in seq: - proper_sequence_names.append(f"{schema}.{seq}") + proper_sequence_names.append(f'{schema}."{seq}"') else: proper_sequence_names.append(seq) targeted_sequences = proper_sequence_names diff --git a/tests/integration/files/test_schema_data.sql b/tests/integration/files/test_schema_data.sql index f4337c8..43bad1a 100644 --- a/tests/integration/files/test_schema_data.sql +++ b/tests/integration/files/test_schema_data.sql @@ -31,7 +31,7 @@ ALTER TABLE public."UsersCapital" OWNER TO owner; CREATE TABLE public."UsersCapital2" ( id bigint NOT NULL, - hash_firstname text NOT NULL, + "hash_firstName" text NOT NULL, hash_lastname text NOT NULL, gender character varying(6) NOT NULL, CONSTRAINT users_gender_check CHECK (((gender)::text = ANY (ARRAY[('male'::character varying)::text, ('female'::character varying)::text]))) @@ -62,7 +62,7 @@ CREATE INDEX users2_idx ON public."UsersCapital" ( -- Name: userS_id_seq; Type: SEQUENCE; Schema: public; Owner: owner -- -CREATE SEQUENCE public.userS_id_seq +CREATE SEQUENCE public."userS_id_seq" START WITH 1 INCREMENT BY 1 NO MINVALUE @@ -70,7 +70,7 @@ CREATE SEQUENCE public.userS_id_seq CACHE 1; -ALTER TABLE public.userS_id_seq OWNER TO owner; +ALTER TABLE public."userS_id_seq" OWNER TO owner; -- -- Name: users2_id_seq; Type: SEQUENCE; Schema: public; Owner: owner @@ -111,7 +111,7 @@ INSERT INTO public."UsersCapital" (id, hash_firstname, hash_lastname, gender) -- Data for Name: Users2; Type: TABLE DATA; Schema: public; Owner: owner -- -INSERT INTO public."UsersCapital2" (id, hash_firstname, hash_lastname, gender) +INSERT INTO public."UsersCapital2" (id, "hash_firstName", hash_lastname, gender) VALUES (1, 'garbagefirst', 'garbagelast', 'male'), (2, 'garbagefirst1', 'garbagelast1', 'female'), (3, 'sdgarbagefirst', 'dgsadsrbagelast', 'male'), @@ -123,7 +123,7 @@ INSERT INTO public."UsersCapital2" (id, hash_firstname, hash_lastname, gender) -- Name: userS_id_seq; Type: SEQUENCE SET; Schema: public; Owner: owner -- -SELECT pg_catalog.setval('public.userS_id_seq', 1, false); +SELECT pg_catalog.setval('public."userS_id_seq"', 1, false); --