feat: pgbelt now supports non-public schemas! #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
vjeeva
force-pushed
the
vjeeva/non-public-schemas
branch
from
37b1b8f
to
aaa9c80
Compare
vjeeva
force-pushed
the
vjeeva/non-public-schemas
branch
3 times, most recently
from
86fc941
to
6c9b075
Compare
…and revoke) fix: oops wrong var name
fix: comment update and update due to rebase
…ner CREATE permissions in the target DB fix: missed some stuff
…e detected due to size detection code
fix: missed some spots
vjeeva
force-pushed
the
vjeeva/non-public-schemas
branch
from
6c9b075
to
f19635b
Compare
jdcallet
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #397.
Note this PR will only be merged once integration tests are added for this. This will be done in a separate PR.
Also note, this PR is pretty big. Please read through each commit instead to get a better understanding of the code change. This is backwards compatible!