Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow deregistering/deqeueing of certain assets that break QM #695

Open
rebeccahum opened this issue Sep 1, 2021 · 0 comments
Open

Comments

@rebeccahum
Copy link
Contributor

rebeccahum commented Sep 1, 2021

What problem would the enhancement address for VIP?

Sometimes certain core assets are deregistered/dequeued which break Query Monitor, which adds an extra step during debugging to track that down.

Dependencies are:

Describe the solution you'd like

It'd be good to have a sniff that warns for specific assets that we do not recommend removing.

What code should be reported as a violation?

wp_deregister_style( 'dashicons' );
wp_dequeue_script( 'jquery' );

What code should not be reported as a violation?

wp_dequeue_style( 'not_dashicons' );
wp_dequeue_script( 'not_jquery' );
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant