Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to PHPCSStandards/PHP_CodeSniffer #806

Closed
kevinfodness opened this issue Dec 27, 2023 · 4 comments
Closed

Migrate to PHPCSStandards/PHP_CodeSniffer #806

kevinfodness opened this issue Dec 27, 2023 · 4 comments

Comments

@kevinfodness
Copy link
Contributor

What problem would the enhancement address for VIP?

Per squizlabs/PHP_CodeSniffer#3932, the squizlabs/php_codesniffer package is being abandoned in favor of phpcsstandards/php_codesniffer. The VIP Coding Standards package depends on the squizlabs version and should be migrated to the phpcsstandards version.

Describe the solution you'd like

Replace the squizlabs/php_codesniffer dependency with phpcsstandards/php_codesniffer at version 3.8.0 (or whatever is current at time of implementation).

@kevinfodness
Copy link
Contributor Author

This will be fixed by #805

@jrfnl
Copy link
Collaborator

jrfnl commented Dec 27, 2023

@kevinfodness Please actually read the announcement and the release notes of the 3.8.0 release:

  • For Composer users, nothing changes.
    In contrast to earlier information, the squizlabs/php_codesniffer package now points to the new repository and everything will continue to work as before.

The phpcsstandards/php_codesniffer package name should NOT be used and, if possible, will be removed from Packagist as soon as all other people who didn't read have migrated back to squizlabs/php_codesniffer.

@jrfnl jrfnl closed this as completed Dec 27, 2023
@jrfnl jrfnl closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2023
@kevinfodness
Copy link
Contributor Author

@jrfnl I apologize, I was acting on outdated information. I read the announcement when it came out, but it seems that the announcement was updated to indicate that changes to Composer installations were no longer required, and I (clearly) didn't read the release notes for v3.8.0. I had updated my fork of this repo and was in the process of creating a PR when I noticed that you already had one started. I appreciate how big of an undertaking this is, and simply wanted to help.

@jrfnl
Copy link
Collaborator

jrfnl commented Dec 28, 2023

@kevinfodness I appreciate the intent. The news that the package name could be retained came a few days after the announcement and before the 3.8.0 release. This news was very welcome as it saves a ton in support issues, but, obviously, it also means that I now need to guard against people acting on outdated information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants