-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to PHPCSStandards/PHP_CodeSniffer #806
Comments
This will be fixed by #805 |
@kevinfodness Please actually read the announcement and the release notes of the 3.8.0 release:
The |
@jrfnl I apologize, I was acting on outdated information. I read the announcement when it came out, but it seems that the announcement was updated to indicate that changes to Composer installations were no longer required, and I (clearly) didn't read the release notes for v3.8.0. I had updated my fork of this repo and was in the process of creating a PR when I noticed that you already had one started. I appreciate how big of an undertaking this is, and simply wanted to help. |
@kevinfodness I appreciate the intent. The news that the package name could be retained came a few days after the announcement and before the 3.8.0 release. This news was very welcome as it saves a ton in support issues, but, obviously, it also means that I now need to guard against people acting on outdated information. |
What problem would the enhancement address for VIP?
Per squizlabs/PHP_CodeSniffer#3932, the
squizlabs/php_codesniffer
package is being abandoned in favor ofphpcsstandards/php_codesniffer
. The VIP Coding Standards package depends on thesquizlabs
version and should be migrated to thephpcsstandards
version.Describe the solution you'd like
Replace the
squizlabs/php_codesniffer
dependency withphpcsstandards/php_codesniffer
at version3.8.0
(or whatever is current at time of implementation).The text was updated successfully, but these errors were encountered: