Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Can only have one instance of [camptix_attendees] per page #175

Open
dd32 opened this issue Apr 20, 2017 · 1 comment
Open

Can only have one instance of [camptix_attendees] per page #175

dd32 opened this issue Apr 20, 2017 · 1 comment

Comments

@dd32
Copy link
Member

dd32 commented Apr 20, 2017

When you attempt to use two instances of the [camptix_attendees] shortcode, perhaps to list one ticket type first, the gravatars fail to load on the 2nd instance.

This appears to be because of the static <div id="tix-attendees"> and the logic in a71f818 only referencing the first attendee listing.

Switching it over to adding a class and using that in the JS would seemingly be a good solution here.

A further change could be to increment the IDs for multiple shortcodes, but that could introduce styling issues for previous WordCamps if they referenced it by ID. Having multiple IDs on pages isn't the end of the world.

@iandunn
Copy link
Contributor

iandunn commented Apr 20, 2017

Good catch, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants