Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled Gallery Block: compatibility with the Gallery Custom Links Plugin #21476

Open
Skyrals opened this issue Oct 20, 2021 · 1 comment
Open
Labels
[Block] Tiled Gallery [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended

Comments

@Skyrals
Copy link

Skyrals commented Oct 20, 2021

Impacted plugin

Jetpack

Steps to Reproduce

Install Gallery Custom Links Plugin by Jordy Meow and activate it

Create a page with a Jetpack tiled mosaic gallery on it using different sized images

A clear and concise description of what you expected to happen.

Gallery should correctly resize images to fit each tile

What actually happened

There are visible gaps between tiles as images are not resized correctly to fit tile

Other information

The CSS is incorrect, this additional CSS override will fix it:

.tiled-gallery__item > a, .tiled-gallery__item > a > img, .tiled-gallery__item > img {
height: 100% !important;
}

Operating System

Windows

OS Version

Windows 10

Browser

Chrome/Chromium

Browser Version(s)

latest

@Skyrals Skyrals added the [Type] Bug When a feature is broken and / or not performing as intended label Oct 20, 2021
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Oct 20, 2021
@jeherve
Copy link
Member

jeherve commented Oct 21, 2021

Thanks for the report.

Related: WordPress Core will start supporting links for gallery images in the next major version of WordPress, thanks to this change WordPress/gutenberg#25940 This should allow Jetpack's Tiled Gallery Block to benefit from that change and support custom links too: #13760

@jeherve jeherve changed the title Jetpack tiled mosaic compatibility Tiled Gallery Block: compatibility with the Gallery Custom Links Plugin Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Tiled Gallery [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants