Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown doesn't work for WooCommerce short product descriptions #2396

Closed
ericelliott opened this issue Jul 11, 2015 · 4 comments
Closed

Markdown doesn't work for WooCommerce short product descriptions #2396

ericelliott opened this issue Jul 11, 2015 · 4 comments
Labels
[Feature] Markdown [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@ericelliott
Copy link

Summary

The Jetpack markdown feature doesn't work for WooCommerce short product descriptions.

Steps to reproduce

  • Activate jetpack and the Markdown extension
  • Create a WooCommerce product
  • Use Markdown syntax for both the short and long product descriptions
  • Save the product

Expected behavior

The Markdown descriptions should be transformed into HTML for display.

Actual behavior

  • The short description is not converted.
  • The long description is converted.

Screenshot

screen shot 2015-07-11 at 3 26 57 pm

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Markdown [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Type] Bug When a feature is broken and / or not performing as intended labels Jul 11, 2015
@kraftbj
Copy link
Contributor

kraftbj commented Jul 11, 2015

I'm unsure if this is a problem on our end, WooTheme's end, or neither. I'm not familiar enough with WC yet to be sure. Notably, I'm not sure what actually generates the short description and if it is something that Jetpack ever expected to be markdown'd. Currently, we look for the post content in supported post types (WC products having declared support for markdown in their plugin).

It appears the short description is based on the excerpt.

If so, the real request is to enable Markdown conversion on the excerpt for support post types; however, by default, the_excerpt strips down to 55 words with no HTML (unless a plugin rebuilds it, which is my initial thought on what WC does). In other words, the average WordPress install wouldn't support non-plain-text excerpts in either case.

Based on #155 (comment), I think this is something that could be raised on WooCommerce's GitHub as an improvement if they'd like to offer Markdown support for short descriptions.

Leaving it open for a second set of eyes, but I think this is a wontfix punting to WooCommerce.

@mattwiebe or @mikejolley, any thoughts?

@ericelliott
Copy link
Author

It appears the short description is based on the excerpt.

WooCommerce lets you use anything you want in the short description. Screenshot:

screen shot 2015-07-11 at 5 56 34 pm

Note that I'm using HTML here instead of Markdown to work around this bug. The rest of my site content uses Markdown.

@claudiosanches
Copy link

Done woocommerce/woocommerce@eea7255

@ericelliott
Copy link
Author

Thanks @claudiosmweb. That was quick! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Markdown [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

3 participants