Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing / Like Blocks: compatibility with theme styles #36410

Open
jeherve opened this issue Mar 15, 2024 · 0 comments
Open

Sharing / Like Blocks: compatibility with theme styles #36410

jeherve opened this issue Mar 15, 2024 · 0 comments
Labels
[Block] Like [Block] Sharing Button [Block] Sharing Buttons [Feature] Likes [Feature] Sharing Post sharing, sharing buttons [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@jeherve
Copy link
Member

jeherve commented Mar 15, 2024

Splitting off discussion from #36382:

The buttons should also be more defensive about theme CSS leaking in (or allow some CSS in, but in the same way for both buttons, whichever works better). I think the like is an iframe so being more defensive might be better. Now they end up looking different size, and different hover effects depending on theme:

image

Shadow dom might also be helpful here.

I'm not sure what's the best way to go about this. On one hand, the design should be consistent between the 2 buttons. On the other, wouldn't we want the fonts and styles to match the rest of the site?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Like [Block] Sharing Button [Block] Sharing Buttons [Feature] Likes [Feature] Sharing Post sharing, sharing buttons [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

1 participant