Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter: improve rendering of embed blocks #39541

Open
simison opened this issue Sep 26, 2024 · 1 comment
Open

Newsletter: improve rendering of embed blocks #39541

simison opened this issue Sep 26, 2024 · 1 comment
Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@simison
Copy link
Member

simison commented Sep 26, 2024

Embeds from Twitter, TikTok, etc are currently rendered as text-only:

Screenshot 2024-09-26 at 11 49 19

We'd like to be able to render something more visual in emails;

Exploration using images with our mShots API, which already has good dedicated support for Twitter embeds:

Screenshot 2024-09-25 at 19 06 07 Screenshot 2024-09-25 at 19 06 14

Slack convo p1726144959645139-slack-C052XEUUBL4

Came up with Team 51 customer p9MPsk-5nT-p2

Exploration in D162345-code

@simison simison added the [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. label Sep 26, 2024
@dhanson-wp
Copy link

A couple more examples of wanting better email rendering.

WordPress Embed

The WordPress Embed block for internal/external site links is a nice card:

image

In email, the WordPress embed just looks like a Quote block:

image

Leveled headings in Group blocks

Designing creative patterns look great in the block editor and the frontend of posts:

image

In emails, while it is fine that a lot of the styles are absent (background gradient, border, etc.), the sizing and spacing of headings and text all feel off.

image

@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

3 participants