Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getFile should emit progress events just like putFile #122

Closed
andrewrk opened this issue Nov 21, 2012 · 5 comments
Closed

getFile should emit progress events just like putFile #122

andrewrk opened this issue Nov 21, 2012 · 5 comments
Labels

Comments

@andrewrk
Copy link
Contributor

it's weird that getFile and putFile have completely different interfaces.

@domenic
Copy link
Contributor

domenic commented Nov 21, 2012

Seems reasonable. Can do; pull request also welcome.

@andrewrk
Copy link
Contributor Author

Maybe you can recommend that people use https://github.com/superjoe30/node-s3-client for high level upload/download functions.

@domenic
Copy link
Contributor

domenic commented Nov 25, 2012

@superjoe30 that's a great library; I'll do that. Reopening this though since it's still tracking a feature I would like, i.e. emitting progress events on getFile.

@domenic domenic reopened this Nov 25, 2012
@domenic
Copy link
Contributor

domenic commented Nov 25, 2012

Wait no I just realized this makes no sense. getFile just gets the response, it doesn't wait for it to finish (or even start) streaming. And there's no progress on the request.

Darn, I guess I got really confused.

@domenic domenic closed this as completed Nov 25, 2012
@andrewrk
Copy link
Contributor Author

Cool no worries. I think we arrived at a good conclusion for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants