Use official SDK as low-level implementation, or clarify advantages of not doing so

[boutell]

I think it makes sense to either use the official AWS SDK as the actual implementation of talking to AWS, or clarify the advantages of avoiding that implementation. It would also be helpful to understand whether the goal is to pursue new features, or just maintain knox for existing apps on the assumption that most users are migrating to the SDK.

I'm suggesting these questions be addressed in the documentation.

[marr]

👍

[aseemk]

We've moved over to the official AWS SDK, and we've been pretty happy.

[stephenyeargin]

@TooTallNate Can you or a teammate weigh on this one? Not sure who all is on the Owner/Collaborator roster.

[avimar]

I don't know if it was on purpose, but andrewrk would say it's a great choice to avoid the official SDK. See: andrewrk/node-s3-client#129

[adamreisnz]

@avimar doesn't he advocate the exact opposite?

So if this module is going to survive, it must be changed to remove the dependency on the aws sdk js package and instead make direct HTTP requests, like knox already does.

And:

I made a fundamental mistake when making this library, which was depending on the official AWS SDK package, which is probably the worst piece of shit JavaScript package I've ever depended on.

[avimar]

@adambuczynski Uhm. That's what I meant. I'm not sure why I worded it that way!