Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report additional information in reviews #232

Closed
6 tasks done
gudmdharalds opened this issue Jan 21, 2022 · 1 comment
Closed
6 tasks done

Report additional information in reviews #232

gudmdharalds opened this issue Jan 21, 2022 · 1 comment

Comments

@gudmdharalds
Copy link
Contributor

gudmdharalds commented Jan 21, 2022

Post additional debug information in GitHub Reviews, including PHP linting version and PHP runtime version. This information is needed as a part of our work to get to PHP 8.0/8.1. This information is important as in the future we need to support multiple PHP versions and in such cases it is useful to know exactly what PHP version was used so to have a good understanding of the scanning environment. Such information can generally be useful for end-users as well.

Ensure this information can be posted in GitHub Reviews and in a standalone GitHub comment, see #40. Use the details HTML tag so to hide the information by default, like this:


Debug information

Run time environment

Software versions

  • PHP runtime version: 8.1
  • PHP linting version: 7.4
  • PHPCS version: 3.6.2

Options altered

  • lint-modified-files-only set to true
  • phpcs-severity set to 3

Directories not scanned

The following directories were not scanned according to the settings provided.

Not PHPCS scanned:

  • src/test1.php
  • src/test2.php

Not PHP linted:

  • src/test1.php
  • src/test4.php

TODO:

  • Report PHP version used for linting
  • Report PHP runtime version
  • Report PHPCS version
  • Report PHPCS standards used and versions (if possible)
  • Report options altered via .vipgoci_options
  • Report version of vip-go-ci
@gudmdharalds
Copy link
Contributor Author

Is resolved in #246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant