Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File upload does not start when selecting the same file #460

Closed
vbelolapotkov opened this issue Feb 24, 2020 · 0 comments · Fixed by #4022
Closed

File upload does not start when selecting the same file #460

vbelolapotkov opened this issue Feb 24, 2020 · 0 comments · Fixed by #4022
Assignees
@alefesouza
Labels
category: core WC Payments core related issues, where it’s obvious. good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. needs prioritisation Triage finished and issues are ready for the following processing. type: bug The issue is a confirmed bug.

Comments

@vbelolapotkov
Copy link
Collaborator

The issue is in the evidence form with FileUpload component which doesn't trigger onChange event when the same file is selected.

Steps to reproduce

  1. Go to dispute evidence form.
  2. Select a file which is not allowed to upload, e.g. .docx. The upload should fail.
  3. Select the same file. Upload won't start again.

Potential solution: introduce error prop in the FileUpload component, and reset input value if error is passed.
@vbelolapotkov vbelolapotkov added category: core WC Payments core related issues, where it’s obvious. good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. type: bug The issue is a confirmed bug. needs prioritisation Triage finished and issues are ready for the following processing. labels Dec 22, 2021
@alefesouza alefesouza mentioned this issue Mar 7, 2022
Closed
@alefesouza alefesouza self-assigned this Mar 7, 2022
@alefesouza alefesouza mentioned this issue Mar 24, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alefesouza alefesouza

Labels
category: core WC Payments core related issues, where it’s obvious. good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. needs prioritisation Triage finished and issues are ready for the following processing. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow file upload to select same file after error Automattic/woocommerce-payments
2 participants
@alefesouza @vbelolapotkov