Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Add justified alignment #28696

Closed
supernovia opened this issue Nov 19, 2018 · 49 comments
Closed

Gutenberg: Add justified alignment #28696

supernovia opened this issue Nov 19, 2018 · 49 comments
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Normal [Type] Enhancement

Comments

@supernovia
Copy link
Contributor

supernovia commented Nov 19, 2018

Several of our users like justifying their text. In Calypso they had an alignment button. In wp-admin, they could use a keyboard shortcut. Now neither seems to work, and those who don't have custom CSS capabilities are left editing each paragraph's style by hand by clicking three dots, edit HTML, adding style, converting to HTML... and so on, for each paragraph. It'd be nice if this were easier for them.

(Edit from @gwwar) To re-add visual controls, it seems unlikely that core would accept such a patch since this was intentional (removed in WordPress 4.7), but I think we can consider it as a WordPress.com integration if folks really want this. Underline in particular was hidden to reduce confusion on what is and is not a link, while Justify was removed due to spotty browser implementations.

At the time of this update, this is one of the most common bugs/feedback we've received from the Gutenberg rollout.

For reference, this is what Underline and Justify Options in the Calypso Classic Editor look like
screen shot 2018-11-28 at 7 56 50 am

Update 1/23: @gziolo and @jasmussen note that the core Gutenberg project would be open to adding justify and underline, disabled by default, but re-addable as a user option. So for folks taking on this task, try starting with a core patch first, unless things get stuck and be sure to test mobile views and the block toolbar in nested contexts, as this adds additional buttons to the toolbar width.

See related: WordPress/gutenberg#13117, though we'll want to add visual UI here rather than just a keyboard shortcut.

Update (@Copons):
This is currently live on WordPress.com Simple sites, and will remain a WordPress.com-only enhancement for the time being.

Update 2 (@Copons)
The solution mentioned in the first update is good enough for Simple sites, but we should have a better designed approach for other site types.
This kind of better design likely involves adding an extension point to the Alignment Toolbar (justify should be a block alignment attribute, not an inline format), which is not really straightforward.
I've tried experimenting a bit (WordPress/gutenberg#14824), but couldn't figure out a good and sensible way to proceed, that's also good enough to be reusable by other developers in the wild.

@supernovia supernovia added [Type] Enhancement [Goal] Gutenberg Working towards full integration with Gutenberg labels Nov 19, 2018
@supernovia
Copy link
Contributor Author

https://en.forums.wordpress.com/topic/new-post-editor-3/

Noting we've had other folks asking too. :)

@KokkieH
Copy link
Contributor

KokkieH commented Nov 20, 2018

The broken keyboard shortcuts are being worked on in Core in WordPress/gutenberg#8450

@tbradsha
Copy link
Contributor

tbradsha commented Nov 23, 2018

See also: p7DVsv-5F7-p2

@erricgunawan
Copy link

I have one from 3960759-hc

@supernovia
Copy link
Contributor Author

@katiebethbrown
Copy link

Another in 3198529-hc

@sdixon194
Copy link
Contributor

1603732-zen

@tbradsha
Copy link
Contributor

tbradsha commented Dec 1, 2018

1611421-zen

@gemmagarner
Copy link

Requested on Twitter.

@arunsathiya
Copy link
Contributor

#7819824-hc

@katinthehatsite
Copy link
Contributor

Another in #1647561-zd

@Aurorum
Copy link
Contributor

Aurorum commented Dec 15, 2018

Another request in the forums: https://en.forums.wordpress.com/topic/justify-text-3/#post-3232361

@azollafox
Copy link

Another in #1650446-ZD and #1649983-ZD

@nerdysandy
Copy link
Contributor

8875156-hc

@donalirl
Copy link

Another request for Justify in #8879202-hc

@SiobhyB
Copy link
Contributor

SiobhyB commented Dec 19, 2018

This was requested in the app in 1652134-z also. (Although this was for the app, adding here as it shows demand for a justify option and it's unlikely to be added to the app without first being added to Gutenberg.)

@Aurorum
Copy link
Contributor

Aurorum commented Dec 24, 2018

Another user looking for this feature in the forums: https://en.forums.wordpress.com/topic/how-can-i-justify-text-in-the-new-layout/

@arunsathiya
Copy link
Contributor

1680099-zen

@aamills
Copy link

aamills commented Jan 2, 2019

Another user would like the option, here 9082543-hc

@Aurorum
Copy link
Contributor

Aurorum commented Jan 3, 2019

@rossanafmenezes
Copy link

Another one here 1693452-zen

@SiobhyB
Copy link
Contributor

SiobhyB commented Jan 5, 2019

A review for the app:

There is no option for Justified text, the posts looks too odd without Justified option in the text paragraph.

(As before: Although this was feedback for the app, adding here as it shows demand for a justify option and it's unlikely to be added to the app without first being added to Gutenberg.)

@gemmagarner
Copy link

Requested on Twitter.

@SiobhyB
Copy link
Contributor

SiobhyB commented Jan 17, 2019

Another request in 1720247-zen.

@Aurorum
Copy link
Contributor

Aurorum commented Jan 31, 2019

@m
Copy link
Contributor

m commented Feb 2, 2019

As suggested in this comment, it doesn't look like we're correctly responding to users that they can justify the design with CSS without having to manually set every paragraph:

WordPress/gutenberg#8450 (comment)

@Aurorum
Copy link
Contributor

Aurorum commented Feb 2, 2019

That's true, but I think the intention of this issue is to allow those without access to CSS to be able to justify text in a more efficient way.

Those who don't have custom CSS capabilities are left editing each paragraph's style by hand by clicking three dots

@bakenshake
Copy link

I manually set every paragraph using HTML, and my text did not justify. I work in a university setting, and my boss requires all of our pages to have justified text. Hope this gets added soon.

@Aurorum
Copy link
Contributor

Aurorum commented Feb 18, 2019

@zdenys
Copy link
Contributor

zdenys commented Feb 23, 2019

Another report here 1825832-zen

@katiebethbrown
Copy link

One more in 10757717-hc

@zdenys
Copy link
Contributor

zdenys commented Mar 7, 2019

11021623-hc

@Aurorum
Copy link
Contributor

Aurorum commented Mar 9, 2019

@Gilmoursa
Copy link

3162117-hc

@gpmw
Copy link

gpmw commented Mar 21, 2019

And another #8574984-hc

@Agepeuve
Copy link

Another request in 1903732-zen

@sarahcada
Copy link

Another at 11536771-hc

@Copons Copons self-assigned this Mar 28, 2019
@julsyd
Copy link

julsyd commented Apr 1, 2019

Requested in 1903618-zen.

@Copons
Copy link
Contributor

Copons commented Apr 1, 2019

Requested in 1903618-zen.

@juliasydnor This should have been fixed for Simple sites on Friday by D26137-code (added the Justify button to the Paragraph block toolbar), and we are in process of enabling it for JP and AT.
I don't have access to 1903618-zen, so could you please tell me if it's a Simple and therefore there are other issues going on?

@julsyd
Copy link

julsyd commented Apr 1, 2019

@Copons Good to know, I haven't seen an announcement about the update.

The user had already switched back to the Classic editor. Their ticket was submitted before Friday, so they wouldn't have seen the option then. I do see the option on my simple sites using Gutenberg, so we should be all set.

@Copons
Copy link
Contributor

Copons commented Apr 1, 2019

@juliasydnor Great, thanks!
We haven't advertised it because the button location is temporary, pending Core changes. 🙂

@scruffian
Copy link
Member

I think this is a core issue. Should we close this one and track it there?

@Copons
Copy link
Contributor

Copons commented Apr 3, 2019

@scruffian The button is live on WPCOM Simple, but I'm keeping this issue open to remember porting it on JP/AT when possible.

@gwwar
Copy link
Contributor

gwwar commented Apr 3, 2019

@scruffian see also the comments conversation in p7jreA-2em-p2

@Copons do you mind updating the summary of this issue to reflect that this is a wpcom enhancement for now?

@Copons Copons removed their assignment Apr 18, 2019
@mmtr
Copy link
Member

mmtr commented May 11, 2019

Closing this since the custom format types have been moved to the wpcom-block-editor package and they are available in JP/AT sites (Automattic/jetpack#12070).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Normal [Type] Enhancement
Projects
None yet
Development

No branches or pull requests