Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Block Toolbar in header obscures the content of the blocks #55982

Closed
mrfoxtalbot opened this issue Sep 3, 2021 · 7 comments
Closed

FSE: Block Toolbar in header obscures the content of the blocks #55982

mrfoxtalbot opened this issue Sep 3, 2021 · 7 comments
Labels
[Goal] Full Site Editing [Pri] Normal Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@mrfoxtalbot
Copy link

mrfoxtalbot commented Sep 3, 2021

Steps to Reproduce

Edit a site's header using Full Site Editing

What I expected to happen

I expected to be able to edit the blocks in the site's header template part.

What actually happened

The lack of top padding in the site header template part "nudges down" the toolbar for each of the blocks, obscuring the block itself.

Screen Shot 2021-09-01 at 15 29 21

Context

FSE testing

Operating System

macOS

OS Version

BigSur 11.1

Browser

Chrome/Chromium

Browser Version(s)

92.0.4515.159

Is this specific to applied theme? If so, what is the theme name?

Nope

Simple/Atomic

Atomic

Console and/or error logs

No response

Number of Users Impacted

No response

Available Workarounds

You can add a temporary spacing block at the very top of the header to create extra space, but it is a bit of a hack and not something most users will come up with.

Reproducibility

Consistent

Other information

No response

@mrfoxtalbot mrfoxtalbot added [Type] Bug [Goal] Full Site Editing User Report This issue was created following a WordPress customer report labels Sep 3, 2021
@formosattic
Copy link

Thanks @mrfoxtalbot!

✅ Reproduced

@formosattic formosattic added the Triaged To be used when issues have been triaged. label Sep 14, 2021
@synora
Copy link
Contributor

synora commented Oct 19, 2021

Also reported in p7DVsv-cAa-p2#comment-37499

@jeyip
Copy link
Contributor

jeyip commented Nov 4, 2021

Just to clarify, I could only see the "nudging" behavior when navigating to header template part editing through the ellipses menu.

Screen Shot 2021-11-03 at 5 15 36 PM

@creativecoder
Copy link
Contributor

I wonder if we could apply the same logic we use in the Site Editor to move the block toolbar below the block when there's not enough room on the screen.

Site Editor Isolated Template Part
Screen Shot 2021-11-04 at 12 40 20 Screen Shot 2021-11-04 at 12 40 34

See WordPress/gutenberg#33981

This should be fixed in Gutenberg, as it's not specific to WP.com.

@jeyip jeyip self-assigned this Nov 4, 2021
@jeyip
Copy link
Contributor

jeyip commented Nov 12, 2021

A few interesting observations I noted:

  • I only see the nudging on initial load of the isolated template part view when navigating from the show template part details ellipses menu. If the isolated editor is resized or if the page is refreshed, the block toolbar renders as expected.
  • The nudging only happens on initial load if the viewport width is narrow enough.

@jeyip jeyip removed their assignment Nov 16, 2021
@Addison-Stavlo
Copy link
Contributor

related - WordPress/gutenberg#36977 - the bottom positioning can obscure children blocks in popovers/dropdown as is the case when triggered with the navigation block.

@Addison-Stavlo
Copy link
Contributor

I believe this issue was resolved in core Gutenberg recently - WordPress/gutenberg#36977 - closing the issue for now, but if you continue to experience this please feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Full Site Editing [Pri] Normal Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

7 participants